[kstyle] use Q_FALLTHROUGH in breezesplitterproxy
ClosedPublic

Authored by zzag on Apr 1 2018, 11:40 AM.

Details

Summary

Qt has its own macro to tell the compiler that the lack of the break
statement is intentional. One of the advantages of using Q_FALLTHROUGH
is that it explicitly says other developers that the break statement is
missing on purpose. Another advantage is that we can use directives,
see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77817

Test Plan

Compiled Breeze with GCC 7 and Clang, no "this statement may fall
through" warnings whatsoever.

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Apr 1 2018, 11:40 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 1 2018, 11:40 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Apr 1 2018, 11:40 AM
davidedmundson accepted this revision.Apr 2 2018, 10:22 PM
This revision is now accepted and ready to land.Apr 2 2018, 10:22 PM
This revision was automatically updated to reflect the committed changes.