Add syntax highlighting for Logcat
ClosedPublic

Authored by nibags on Mar 31 2018, 11:13 PM.

Details

Summary

Add the XML file for Android Logcat.

This syntax highlighting file supports all log formats, including the long format (see: test.logcat).

More details:

Diff Detail

Repository
R216 Syntax Highlighting
Branch
add-logcat (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
nibags created this revision.Mar 31 2018, 11:13 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 31 2018, 11:13 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
nibags requested review of this revision.Mar 31 2018, 11:13 PM
nibags edited the summary of this revision. (Show Details)Mar 31 2018, 11:15 PM
cullmann accepted this revision.Apr 8 2018, 9:21 AM
cullmann added a subscriber: cullmann.

I think it looks ok, no hard-coded colors, it seems to pass the basic static checks and we have a testcase.
I would more like to have a test case in plain english, but the text just seems to be some random excert out of some old book, if google translate doesn't cheat me.

This revision is now accepted and ready to land.Apr 8 2018, 9:21 AM

It's a poem by Nicanor Parra. If you want I can change the test for a real log...

nibags updated this revision to Diff 31729.Apr 9 2018, 9:55 AM
  • New test file.

I also merged some RegExpr rules.

nibags updated this revision to Diff 31767.Apr 9 2018, 7:52 PM
  • I added two lines to the test file

Everything is ready. But my account is not developer and I do not have permission to push it to the repository.

This revision was automatically updated to reflect the committed changes.