Remove categories from app delegates
ClosedPublic

Authored by ngraham on Mar 31 2018, 6:45 PM.

Details

Summary

This patch removes category labels from the app delegates, for the following reasons:

  • They're not very useful in the first place; the caption generally provides all the information you need without click on it for a more detailed view
  • They clutter up the presentation and make it harder to parse quickly
  • For certain apps and certain views, they sometimes don't show up at all, which is confusing and inconsistent
Test Plan

Looks better, and it's easier to quickly parse the list:

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Mar 31 2018, 6:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 31 2018, 6:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 31 2018, 6:45 PM
ngraham edited the test plan for this revision. (Show Details)Mar 31 2018, 6:47 PM
ngraham updated this revision to Diff 31109.Apr 1 2018, 5:12 PM

Rebase on master

ngraham edited the test plan for this revision. (Show Details)Apr 1 2018, 5:12 PM
rkflx added a subscriber: rkflx.Apr 7 2018, 11:38 AM

FWIW, have a +1 for the idea. Removing the categories is not ideal, but having the ratings can be much more enticing for the user to install the app, and there is only so much space… Thus I think it's the better compromise to go with the ratings.


BTW, could not run the patch, because Discover master fails to start for me:

QQmlApplicationEngine failed to load component
qrc:/qml/DiscoverWindow.qml:159 Cannot assign to non-existent property "showCloseButton"

Any tips? I ran this on a non-master KF5/Plasma desktop, but CMake did not complain so it should be fine, right?

One more thing: Lately I'm missing the "before" screenshots in your patches, although they would be really helpful! (If you installed to ~/usr instead of /usr, for non-unique apps you could even run both versions in parallel for all your screenshotting needs, or in sequence for unique apps…)

FWIW, have a +1 for the idea. Removing the categories is not ideal, but having the ratings can be much more enticing for the user to install the app, and there is only so much space… Thus I think it's the better compromise to go with the ratings.


BTW, could not run the patch, because Discover master fails to start for me:

QQmlApplicationEngine failed to load component
qrc:/qml/DiscoverWindow.qml:159 Cannot assign to non-existent property "showCloseButton"

Any tips? I ran this on a non-master KF5/Plasma desktop, but CMake did not complain so it should be fine, right?

Yeah, we're depending on a feature in the KF 5.45 version of Kirigami, We should mark that dependency.

One more thing: Lately I'm missing the "before" screenshots in your patches, although they would be really helpful! (If you installed to ~/usr instead of /usr, for non-unique apps you could even run both versions in parallel for all your screenshotting needs, or in sequence for unique apps…)

Sure, I'll try to get back to including before examples too. It's not technically challenging, I'm just being lazy. :-)

This revision was not accepted when it landed; it landed in state Needs Review.Apr 8 2018, 11:19 PM
This revision was automatically updated to reflect the committed changes.