Pluginize reports view
ClosedPublic

Authored by wojnilowicz on Mar 31 2018, 9:51 AM.

Details

Summary

This patch makes reports view optional instead of mandatory. User can switch on and off this view and have more space on views pane.
Developers will benefit by saving on build time of this plugin.

This patch introduces kmm_menus shared library for QActions to work seamlessly across plugin interface. It's worth considering merge with settings and icons in the future, as these libraries are often required together.

Diff Detail

Repository
R261 KMyMoney
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wojnilowicz requested review of this revision.Mar 31 2018, 9:51 AM
wojnilowicz created this revision.
tbaumgart requested changes to this revision.Mar 31 2018, 10:51 AM

Works for me with the following patch applied:

diff --git a/kmymoney/menus/menuenums.h b/kmymoney/menus/menuenums.h
index ac275378..bc59e434 100644
--- a/kmymoney/menus/menuenums.h
+++ b/kmymoney/menus/menuenums.h
@@ -19,6 +19,8 @@
 
 #include "kmm_menus_export.h"
 #include <QHashFunctions>
+#include <QHash>
+
 class QAction;
 class QMenu;

Also, you should add a reports/.krazy file to avoid krazy complaints about the empty .kcfg file. See forecast/.krazy as reference.

This revision now requires changes to proceed.Mar 31 2018, 10:51 AM
This revision was not accepted when it landed; it landed in state Needs Revision.Mar 31 2018, 12:47 PM
This revision was automatically updated to reflect the committed changes.

Also, you should add a reports/.krazy file to avoid krazy complaints about the empty .kcfg file. See forecast/.krazy as reference.

I did it without that, because I see that krazy complaints nevertheless and I think it may complain about commented stuff, which isn't present in .kcfg file from this patch.