Fix crash when using resetColorScheme()
ClosedPublic

Authored by ahmadsamir on Mar 30 2018, 8:58 PM.

Details

Summary

After the KNewStuff changes that were added to
EditProfileDialog::removeColorScheme(), now when
resetColorScheme() calls removeColorScheme() Konsole crashes.
Change resetColorScheme() to call ColorSchemeManager::deleteColorScheme()
directly; this is more logical since there's no need to delete the row
from the color schemes list as reseting the color scheme just deletes
the relevant color scheme from the user's home dir and "re-adds" the
original one from the system-wide location.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Mar 30 2018, 8:58 PM
Restricted Application added a project: Konsole. · View Herald TranscriptMar 30 2018, 8:58 PM
ahmadsamir requested review of this revision.Mar 30 2018, 8:58 PM
hindenburg edited the summary of this revision. (Show Details)Mar 31 2018, 1:26 AM
hindenburg accepted this revision.Mar 31 2018, 1:29 AM

nice catch -thanks

This revision is now accepted and ready to land.Mar 31 2018, 1:29 AM
This revision was automatically updated to reflect the committed changes.