the track number is not important for the all tracks view, so move it to a less prominent position
Diff Detail
Diff Detail
- Repository
- R255 Elisa
- Branch
- tracks_display
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Well, I find the look to be very strange. It looks different from the playlist even if both can be seen at the same time.
Are you sure this is a good idea ?
Did you ask vdg ?
You can easily ping them directly from phabricator.
Comment Actions
The initial reasoning was that I've added sorting to each view, and decided to sort by title for the all tracks view (no option to choose different sort "columns" currently) and then it just looked weird, because the numbers were totally scattered.
Since then I found this sorting option not to be very intuitive at all and implemented sorting that takes more information into account, where it looks just fine.
One could still argue that for an all tracks view the title is the most important aspect and not its position in an album, but I'm also not super convinced about this one anymore. So I'm fine with dropping this patch entirely or wait until we get feedback from the VDG.
@VDG any opinions?
Comment Actions
Hmm, not sure I like this. Having the tracks in the header seems more user-friendly than shunting them off to the album line, with which which they have no visual or logical connection.
Why are the tracks out of order in the "Before" screenshot?
Comment Actions
Ok, let's drop this. The issue with the numbers in the first screenshot is that we do not have proper sorting implemented, which I'm working on.