avoid Asan runtime error: shift exponent -1 is negative
ClosedPublic
Actions

Authored by jtamate on Mar 30 2018, 5:28 PM.

Details

Reviewers

Group Reviewers

Kate
Frameworks

Commits

Summary

Avoid doing a 1<<-1.

Test Plan

Before: frameworks/ktexteditor/src/completion/katecompletionconfig.cpp:195:33: runtime error: shift exponent -1 is negative
after: silence

Repository

R39 KTextEditor

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

jtamate requested review of this revision.Mar 30 2018, 5:28 PM

Change looks good (the previous code definitely looks like nonsense), but what does this mean for existing settings, saved previously?

maybe instead make it explicit what the old code did instead? i.e. check what you get from GCC for "1 << -1" and then use that when i == 0

Implemented mwolf solution.

thanks

This revision is now accepted and ready to land.Apr 4 2018, 10:23 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/completion/katecompletionconfig.cpp (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	30952			Mar 30 2018, 5:24 PM	★	★
Diff 2	31271			Apr 4 2018, 10:13 AM	★	★
Diff 3	31312	0b28572	R39:3e8bbe0ad8385758fbaea74366e77be735a91caa	Apr 4 2018, 5:43 PM	★	★