[colorcorrection] Set gamma through Output class
ClosedPublic

Authored by romangg on Mar 30 2018, 1:08 PM.

Details

Summary

With the new Output class we can set the gamma directly here. This is also
a stepping stone to adjust individual output gamma adjustment later on.

This means any future backend, which aims to support the color correction
frontend needs to use the Output class.

Test Plan

Night Color test still passes.

Diff Detail

Branch
gammaInOutput
Lint
No Linters Available
Unit
No Unit Test Coverage
romangg created this revision.Mar 30 2018, 1:08 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 30 2018, 1:08 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Mar 30 2018, 1:08 PM
romangg updated this revision to Diff 30935.Mar 30 2018, 1:12 PM

Add missing override keyword

romangg updated this revision to Diff 30936.Mar 30 2018, 1:13 PM

Retry arc

graesslin accepted this revision.Apr 5 2018, 6:01 PM
This revision is now accepted and ready to land.Apr 5 2018, 6:01 PM
romangg updated this revision to Diff 33440.May 1 2018, 8:11 PM

Rebase on parent revision changes

romangg updated this revision to Diff 35364.Jun 1 2018, 6:48 PM

Rebase on parent revision changes

zzag added a subscriber: zzag.Jun 1 2018, 8:31 PM
zzag added inline comments.
plugins/platforms/drm/drm_output.h
140

Shouldn't the gamma parameter be const?

zzag added a comment.Jun 1 2018, 8:32 PM

As a side note: GammaRamp seems to be unsafe. GammaRamp allocates memory, but doesn't provide(or delete) copy constructor, this can cause big problems in some cases.

romangg updated this revision to Diff 35695.Jun 6 2018, 5:26 PM
romangg marked an inline comment as done.
  • const Gamma parameter
  • Rebase on parent revision changes
This revision was automatically updated to reflect the committed changes.