Differential D11801

remove m_desktopContainments
ClosedPublic
Actions

Authored by mart on Mar 30 2018, 11:09 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:5898499c1f8f: remove m_desktopContainments
Summary

with new corona containment query functions in D11361 the data
copy done in m_desktopContainments is no more necessary: this should
make things a bit more simple and robust

Test Plan

launched plasmashell, tried to add/remove activities and screens, all keeps working

Diff Detail

Repository
R120 Plasma Workspace
Branch
phab/m_desktopContainments
Lint
No Linters Available
Unit
No Unit Test Coverage
mart created this revision.Mar 30 2018, 11:09 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 30 2018, 11:09 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart requested review of this revision.Mar 30 2018, 11:09 AM
davidedmundson added a subscriber: davidedmundson.Apr 1 2018, 9:27 PM

Now that previous containmentForScreen patch is looking a thousand times better. Good stuff.

+1

shell/shellcorona.cpp
1256

This shouldn't be needed if we pass it as an arg to containmentForScreen

1596

fix

mart updated this revision to Diff 31201.Apr 3 2018, 9:30 AM
  • setting activity is base corona's job
mart marked 2 inline comments as done.Apr 3 2018, 9:31 AM
davidedmundson accepted this revision.Apr 11 2018, 1:25 PM
This revision is now accepted and ready to land.Apr 11 2018, 1:25 PM
Closed by commit R120:5898499c1f8f: remove m_desktopContainments (authored by mart). · Explain WhyApr 16 2018, 9:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/shellcorona.h (2 lines)
Mshell/shellcorona.cpp (62 lines)

Diff 30916

View Options

shell/shellcorona.h

Loading...
View Options

shell/shellcorona.cpp

Loading...