Fix lua backend, which ignored first running entry
ClosedPublic

Authored by sirgienko on Mar 29 2018, 8:56 PM.

Details

Summary

Before, lua backend was launched with worksheet loading and have time for parsing lua start information (Lua 5.2.4 Copyright (C) 1994-2015 Lua.org, PUC-Rio). But now, first command go to lua, before start information parsing and this leads, that output of this command erroneously be removed. So I add @asemke suggestion, that solve this problem.

Test Plan
  1. Run lua backend without patch and check, that first runned entry haven't output result.
  2. Apply patch
  3. Check, that now first runned entry have output result.

Diff Detail

Repository
R55 Cantor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sirgienko created this revision.Mar 29 2018, 8:56 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMar 29 2018, 8:56 PM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
sirgienko requested review of this revision.Mar 29 2018, 8:56 PM
asemke added a subscriber: asemke.Mar 30 2018, 7:42 AM

Is this problem also solved just by adding

m_process->waitForStarted();
m_process->waitForReadyRead();

after m_process->start() in LuaSession::login()?

sirgienko updated this revision to Diff 30907.Mar 30 2018, 8:59 AM

Yes, @asemke , you right. Your solution is better, so i update the diff.

sirgienko edited the summary of this revision. (Show Details)Mar 30 2018, 9:02 AM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2018, 7:59 AM
This revision was automatically updated to reflect the committed changes.