Differential D11786

Fix returning of data in the helper example
ClosedPublic
Actions

Authored by volkov on Mar 29 2018, 3:51 PM.

Details

Reviewers
None
Group Reviewers
Frameworks
Commits
R283:de225f87ae11: Fix returning of data in the helper example
Summary

ActionReply::data() returns a value, not a reference, so its
modifications will be lost. Use ActionReply::addData() instead.
Also update the documentation.

Diff Detail

Repository
R283 KAuth
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
volkov created this revision.Mar 29 2018, 3:51 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 29 2018, 3:51 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
volkov requested review of this revision.Mar 29 2018, 3:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 10 2018, 1:02 PM
Closed by commit R283:de225f87ae11: Fix returning of data in the helper example (authored by volkov). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mexamples/helper.cpp (2 lines)
Msrc/kauthactionreply.h (3 lines)

Diff 31812

View Options

examples/helper.cpp

Loading...
View Options

src/kauthactionreply.h

Loading...