Point the "View page source" link on the current page to its source file in the Phabricator git repository
Details
Details
- Reviewers
fabianr romangg - Group Reviewers
KDE Human Interface Guidelines - Commits
- R985:a7e86ef854a4: Point "View page source" link to the git source file of the current page
Diff Detail
Diff Detail
- Repository
- R985 KDE Human Interface Guidelines
- Branch
- arcpatch-D11769
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Fix some bugs, refactor and clean up code
- Remove unused code.
- Because the root path "/" points to "/index.html", we set the root path to always be "/index.html".
- Also exclude the "/" at the beginning of the newPath for non-root paths.
- Change the wording in the function description.
- Add return statement within the if block to end execution after "View page source" link is updated, and return the URL for the page's source file in Phabricator (useful for debugging).
This comment was removed by richardbowen.
| source/_static/js/custom.js | ||
|---|---|---|
| 16 | Why are you returning the href? The return value is not used anywhere. | |
Comment Actions
I thought it was a useful addition to show the link to the page's Phabricator repo in the js console. It's either that or return nothing.