Remove Recently Saved This Month and Recently Saved Last Month entries by default
ClosedPublic

Authored by ngraham on Mar 28 2018, 3:42 PM.

Details

Summary

Remove the Recently SavedThis Month and Recently SavedLast Month entries from the Places panel for new installs. This is for the following reasons:

  1. "This Month" and "Last Month" aren't actually recent at all
  2. The functionality of these two entries is very infrequently used, and doesn't deserve to be featured so prominently
  3. This functionality is already available via the Find panel

This change improves the signal-to-noise ratio of the Places panel in the service of T8349: Improve Places panel usability and presentation

Test Plan

Created a new user account, logged into it, and opened Dolphin:

Diff Detail

Repository
R241 KIO
Branch
remove-recently-saved-this-month-and-last-month (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Mar 28 2018, 3:42 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 28 2018, 3:42 PM
ngraham requested review of this revision.Mar 28 2018, 3:42 PM
ngraham edited the test plan for this revision. (Show Details)Mar 28 2018, 3:45 PM

Perhaps remove the yesterday entry and just show recently created with a link to timeline:/ ?

I think the two remaining entries are useful enough to warrant showing them both. timeline:/ is too indirect, and requires at least one extra click to reach the "recently saved today" functionality.

abetts added a subscriber: abetts.Mar 28 2018, 4:42 PM

Can we just call all of those entries just "Recent" or "Recently Used" independent of when it happened? I feel that would be more clear without having to remove the feature.

Can we just call all of those entries just "Recent" or "Recently Used" independent of when it happened? I feel that would be more clear without having to remove the feature.

+1

ngraham added a comment.EditedMar 28 2018, 4:48 PM

We're not removing any features. This patch just removes Recently SavedThis Month and Recently SavedLast Month from the default places panel. The feature is still available via the Find panel.

I would like to rename the feature to just be "Recently used" or "Recent documents" or something like that, but that requires code changes first to make the feature actually show different things (https://bugs.kde.org/show_bug.cgi?id=357542), and would need to be covered in a different patch. That task is already tracked as an entry on T8349, FWIW.

Any more opinions on this patch? Is anyone particularly attached to these entries? Does anyone actually use them from the Places panel in the first place?

+1. Don't use 'em, won't miss 'em.

Okay, unless I hear any impassioned pleas in favor of these entries, I will commit this patch on Saturday, April 7th.

Why is sum(+1) == +3 but noone accepted this? Is there social convention I miss?
(It's scaring me off from simply accepting this.)
+1

In general, people offer a +1 without formally accepting when they generally and vaguely approve, but not enough to:

  • Care that much about it
  • Want to put their formal stamp of approval on it for the purpose of blame if it breaks or proves unpopular

Let me announce that I'm willing to take all the heat from any potential issues, so feel free to offer formal acceptance, folks! :-)

davidedmundson accepted this revision.Apr 4 2018, 2:14 PM
davidedmundson added a subscriber: davidedmundson.

Is there social convention I miss?

It comes from gerrit that most of us use for Qt.

https://gerrit-review.googlesource.com/Documentation/config-labels.html

This revision is now accepted and ready to land.Apr 4 2018, 2:14 PM

Let me announce that I'm willing to take all the heat from any potential issues, so feel free to offer formal acceptance, folks! :-)

Can I have this as a signature?

It comes from gerrit that most of us use for Qt.
https://gerrit-review.googlesource.com/Documentation/config-labels.html

Ah... that clarifies quite a bit, thanks.

Thanks folks.

This revision was automatically updated to reflect the committed changes.
rkflx added a subscriber: rkflx.Apr 4 2018, 11:16 PM

Okay, unless I hear any impassioned pleas in favor of these entries, I will commit this patch on Saturday, April 7th.

Huh?

That was before I got some formal acceptance. I probably should have ended with "if nobody formally accepts by then", which was the intention. This patch had been open for a week...

rkflx added a comment.Apr 4 2018, 11:23 PM

That was before I got some formal acceptance. I probably should have ended with "if nobody formally accepts by then", which was the intention. This patch had been open for a week...

Then don't set Gwenview as a reviewer and announce that you'll give time for review until the weekend. Some people have other plans in the Easter week…

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptSep 25 2018, 3:21 AM