Revert "Revert "Get rid of KDELibs4Support""
ClosedPublic
Actions

Authored by volkov on Mar 27 2018, 11:19 AM.

Details

Reviewers

davidedmundson
broulik

Group Reviewers

Plasma

Commits

R122:e62dd1a185c4: Revert "Revert "Get rid of KDELibs4Support""

Summary

This reverts commit 55603160e9b894270a34e7d01e0aef5bbbfe8025.

"Get rid of KDELibs4Support" was reverted because Can* methods
of PowerManagement class returned incorrect values due to async
DBus calls. Use blocking DBus calls now.

Diff Detail

Repository

R122 Powerdevil

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

volkov created this revision.Mar 27 2018, 11:19 AM

Restricted Application added a project: Plasma. · View Herald TranscriptMar 27 2018, 11:19 AM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

volkov requested review of this revision.Mar 27 2018, 11:19 AM

volkov added reviewers: davidedmundson, broulik, Plasma.Mar 27 2018, 11:20 AM

volkov mentioned this in D4939: Get rid of KDELibs4Support.Mar 27 2018, 11:25 AM

davidedmundson added inline comments.Mar 27 2018, 12:59 PM

CMakeLists.txt
26	I'm confused, the commit description doesn't match the diff

volkov added inline comments.Mar 27 2018, 1:08 PM

CMakeLists.txt
26	What do you mean? It's revert revert...

davidedmundson accepted this revision.Mar 27 2018, 1:14 PM

davidedmundson added inline comments.

CMakeLists.txt
26	Urgh, I have trouble reading words. That's clear. sorry

This revision is now accepted and ready to land.Mar 27 2018, 1:14 PM

volkov closed this revision.Mar 27 2018, 3:07 PM

Revision Contents
Changeset List

		Path
M		CMakeLists.txt (2 lines)
M		daemon/CMakeLists.txt (5 lines)
M		daemon/actions/bundled/CMakeLists.txt (6 lines)
M		daemon/actions/bundled/handlebuttoneventsconfig.cpp (11 lines)
M		daemon/actions/bundled/suspendsessionconfig.cpp (12 lines)
A	M	daemon/org.freedesktop.PowerManagement.Inhibit.xml (20 lines)
A	M	daemon/org.freedesktop.PowerManagement.xml (33 lines)
A	M	daemon/powerdevilpowermanagement.h (63 lines)
A	M	daemon/powerdevilpowermanagement.cpp (208 lines)
M		kcmodule/activities/CMakeLists.txt (2 lines)
M		kcmodule/activities/activitywidget.cpp (9 lines)
M		kcmodule/global/CMakeLists.txt (2 lines)
M		kcmodule/global/GeneralPage.cpp (9 lines)
M		kcmodule/profiles/CMakeLists.txt (2 lines)
M		kcmodule/profiles/EditPage.cpp (12 lines)