Use platform detection from KWorkSpace in KCMShell
ClosedPublic

Authored by fvogt on Mar 27 2018, 7:29 AM.

Details

Summary

In a Wayland session, KCMs need to use the wayland platform plugin.

Test Plan

kcmshell5 kscreen now works properly.

Diff Detail

Repository
R126 KDE CLI Utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Mar 27 2018, 7:29 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 27 2018, 7:29 AM
fvogt requested review of this revision.Mar 27 2018, 7:29 AM

Unset the variable again after app call just to make sure?

fvogt updated this revision to Diff 30731.Mar 27 2018, 3:15 PM

Do the same as krunner, unset the variable if platform got detected.

romangg accepted this revision.Mar 27 2018, 3:26 PM
This revision is now accepted and ready to land.Mar 27 2018, 3:26 PM
This revision was automatically updated to reflect the committed changes.

Please update the dependency metadata in kde-build-metadata.
This has broken the CI builds for kde-cli-tools on all platforms.

fvogt added a comment.Mar 27 2018, 6:04 PM

Please update the dependency metadata in kde-build-metadata.
This has broken the CI builds for kde-cli-tools on all platforms.

The issue here is that plasma-workspace requires kde-cli-tools currently, so adding this dependency would cause a build loop.

I'm not sure why plasma-workspace depends on kde-cli-tools though, it's only a runtime dependency and not a buildtime dependency.

Given this is just runtime, I suggest we just cut it. If it causes issues then the tests which start failing can be remedied later.

fvogt added a comment.Mar 27 2018, 6:13 PM

Given this is just runtime, I suggest we just cut it. If it causes issues then the tests which start failing can be remedied later.

Ok, done.

Thanks, I've initiated rebuilds of kde-cli-tools now.