Have KIO build for Android
ClosedPublic

Authored by apol on Mar 27 2018, 12:15 AM.

Details

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Mar 27 2018, 12:15 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 27 2018, 12:15 AM
apol requested review of this revision.Mar 27 2018, 12:15 AM
aacid added a subscriber: aacid.Mar 28 2018, 11:52 AM

Would it make sense do document the classes/methods that won't work in Android?

apol added a comment.Mar 29 2018, 2:14 AM

Would it make sense do document the classes/methods that won't work in Android?

I was about to do that, but I feel a bit weird because it's as if the rest would work, which I cannot ensure.

PreviewJob will work, just without the shared memory, which in Android doesn't really matter.

diff --git a/src/core/kmountpoint.h b/src/core/kmountpoint.h
index 1762ae8d..ef7bd8cc 100644
--- a/src/core/kmountpoint.h
+++ b/src/core/kmountpoint.h
@@ -83,6 +83,8 @@ public:
      * This function gives a list of all currently used mountpoints. (mtab)
      * @param infoNeeded Flags that specify which additional information
      * should be fetched.
+     *
+     * @note this method is not supported on Android
      */
     static List currentMountPoints(DetailsNeededFlags infoNeeded = BasicInfoNeeded);
In D11734#236186, @apol wrote:

Would it make sense do document the classes/methods that won't work in Android?

I was about to do that, but I feel a bit weird because it's as if the rest would work, which I cannot ensure.

Right

PreviewJob will work, just without the shared memory, which in Android doesn't really matter.

diff --git a/src/core/kmountpoint.h b/src/core/kmountpoint.h
index 1762ae8d..ef7bd8cc 100644
--- a/src/core/kmountpoint.h
+++ b/src/core/kmountpoint.h
@@ -83,6 +83,8 @@ public:
      * This function gives a list of all currently used mountpoints. (mtab)
      * @param infoNeeded Flags that specify which additional information
      * should be fetched.
+     *
+     * @note this method is not supported on Android

supported -> implemented? or "@note this method returns an empty list on Androd" ? I'd like to introduce some "if you want to help let's fix it", but probably a bit too long for a @note ?

 */
static List currentMountPoints(DetailsNeededFlags infoNeeded = BasicInfoNeeded);
apol updated this revision to Diff 31305.Apr 4 2018, 4:23 PM

Include comment saying that method won't work on Android

aacid accepted this revision.Apr 4 2018, 8:29 PM
This revision is now accepted and ready to land.Apr 4 2018, 8:29 PM
This revision was automatically updated to reflect the committed changes.