Differential D11721

Fix issues in models to pass ModelTest
ClosedPublic
Actions

Authored by drosca on Mar 26 2018, 3:34 PM.

Tags

Subscribers

davidedmundson, broulik, plasma-devel

Details

Reviewers

Group Reviewers

Commits

R994:1c9d74bd72e0: Fix issues in models to pass ModelTest
R115:d498ec301bb3: Fix issues in models to pass ModelTest

Test Plan

Did all sort of things with pulseaudio and all ModelTest tests passed.

Diff Detail

Repository

R115 Plasma Audio Volume Applet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

drosca created this revision.Mar 26 2018, 3:34 PM

Restricted Application added a project: Plasma. · View Herald TranscriptMar 26 2018, 3:34 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

whitespace

broulik added a subscriber: broulik.Mar 26 2018, 4:46 PM

broulik added inline comments.

src/maps.h
116	This creates a temporary list just to iterate it, better use iterators and then `key()` provided by it (I bet there's even a fancy `std` algorithm for what you're trying to do here)
src/pulseaudio.h
41	`override`?

Other than Kai's coments, ++ good stuff. thanks

drosca added inline comments.Mar 26 2018, 5:06 PM

src/maps.h
116	Some fancy `std` algorithm gives me iterator, but I need index (and `std::distance` is another traverse because map iterator is not RandomAccessIterator).

fix issues

broulik accepted this revision.Mar 26 2018, 5:07 PM

This revision is now accepted and ready to land.Mar 26 2018, 5:07 PM

Closed by commit R115:d498ec301bb3: Fix issues in models to pass ModelTest (authored by drosca). · Explain WhyMar 26 2018, 5:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/maps.h (23 lines)
M			src/pulseaudio.h (1 line)
M			src/pulseaudio.cpp (30 lines)

Diff 30640

src/maps.h

Loading...

src/pulseaudio.h

Loading...

src/pulseaudio.cpp

Loading...