Fix issues in models to pass ModelTest
ClosedPublic

Authored by drosca on Mar 26 2018, 3:34 PM.

Details

Test Plan

Did all sort of things with pulseaudio and all ModelTest tests passed.

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
drosca created this revision.Mar 26 2018, 3:34 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 26 2018, 3:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
drosca requested review of this revision.Mar 26 2018, 3:34 PM
drosca updated this revision to Diff 30638.

whitespace

broulik added inline comments.
src/maps.h
116

This creates a temporary list just to iterate it, better use iterators and then key() provided by it (I bet there's even a fancy std algorithm for what you're trying to do here)

src/pulseaudio.h
41

override?

Other than Kai's coments, ++ good stuff. thanks

drosca added inline comments.Mar 26 2018, 5:06 PM
src/maps.h
116

Some fancy std algorithm gives me iterator, but I need index (and std::distance is another traverse because map iterator is not RandomAccessIterator).

drosca updated this revision to Diff 30639.Mar 26 2018, 5:06 PM

fix issues

broulik accepted this revision.Mar 26 2018, 5:07 PM
This revision is now accepted and ready to land.Mar 26 2018, 5:07 PM
This revision was automatically updated to reflect the committed changes.