Differential D11719

Fix ď and ť in regular and bold fonts
ClosedPublic
Actions

Authored by hroncok on Mar 26 2018, 2:20 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Commits
R801:2e3c79fd0c05: Fix ď and ť in regular and bold fonts
Summary

My commit in https://github.com/KDE/oxygen-fonts/pull/2 already had the ttfs in it, but this website has an unhandled exception when the patch file contains binary changes, so I've manually removed it.

BUG: 386211

Diff Detail

Repository
R801 Oxygen Fonts
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hroncok requested review of this revision.Mar 26 2018, 2:20 PM
hroncok created this revision.
aacid added reviewers: Plasma, VDG.Mar 26 2018, 5:21 PM
aacid added a subscriber: aacid.

Are we still releasing oxygen fonts?

hroncok added a comment.Mar 26 2018, 9:02 PM

If not, who is?

hroncok added a comment.Mar 26 2018, 10:12 PM

Oh. OK then. Could you please note that in the repo readme?

aacid added subscribers: Plasma, VDG.Apr 3 2018, 10:20 PM

Plasma, VDG people, i'd really welcome some input from your side here.

abetts added a subscriber: abetts.Apr 3 2018, 10:24 PM

Can you please add a screenshot of what this will look like now after the patch?

hroncok added a comment.Apr 4 2018, 9:05 AM

before and after for bold

ngraham edited the summary of this revision. (Show Details)Apr 4 2018, 2:28 PM
ngraham accepted this revision.Apr 4 2018, 2:32 PM
This revision is now accepted and ready to land.Apr 4 2018, 2:32 PM
aacid added a comment.Apr 5 2018, 8:17 PM

@ngraham will you push this?

We still have the problem that this is not being released, but at least it'll be correct on git.

@hroncok would you feel like taking over the maintainership?

hroncok added a comment.Apr 6 2018, 10:28 AM

I know nothing about fonts, about KDE release processes or how to use Phabricator. I could possibly maintain this on GitHub on a "keep alive basis", but that's it.

ngraham added a comment.Apr 7 2018, 1:52 PM

Miro, to land this for you, I need your email address. Also in the future, if you use arc to produce your patch, we won't havr to go through this song-and-dance.

https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

hroncok added a comment.Apr 7 2018, 1:59 PM

miro at hroncok.cz

Closed by commit R801:2e3c79fd0c05: Fix ď and ť in regular and bold fonts (authored by hroncok, committed by ngraham). · Explain WhyApr 7 2018, 2:02 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Apr 7 2018, 2:02 PM

Thanks! I've landed this patch for you.

Revision Contents
Changeset List

Diff 31591

View Options

oxygen-fonts/Regular-400/src/Oxygen-Sans.sfd

Loading...