added kde logo instead of the home button, improved button layout
ClosedPublic
Actions

Authored by fabianr on Mar 26 2018, 1:53 PM.

Details

Reviewers

romangg
richardbowen

Commits

R985:628f9cdb9bbc: added kde logo instead of the home button, improved button layout

Summary

Overwrote some webfont icons to replace the home button with a KDE logo and made the buttons more breeze like

Diff Detail

Repository

R985 KDE Human Interface Guidelines

Branch

layout

Lint

No Linters Available

Unit

No Unit Test Coverage

fabianr requested review of this revision.Mar 26 2018, 1:53 PM

fabianr created this revision.

Are we sure we want to use this license? I don't have any preference but imo the licensing definition should go in a separate patch, because it's important. This way we can get specific feedback on the chosen license by the community.

The current wikis are licensed as CC SA 4.0: https://userbase.kde.org/KDE_UserBase_Wiki:Copyrights

source/conf.py
50	Replace with: copyright = '2018, KDE. Licensed as Creative Commons Attribution 3.0 Unported'

Changed licence to CC-BY-SA 4.0 like the current HIG is licenced

fabianr added a project: KDE Human Interface Guidelines.Mar 28 2018, 12:38 PM

romangg added inline comments.Mar 29 2018, 9:13 AM

source/conf.py
50	ping replace now with: copyright = '2018, KDE. Licensed under Creative Commons License SA 4.0 It's too long otherwise and has one fullstop at the end too many.

+1 Looks good.

The rephrased copyright suggestion by @romangg reads is simpler. +1 as well.

Please change the copyright line, then push.

This revision is now accepted and ready to land.Mar 31 2018, 5:03 PM

fabianr closed this revision.Apr 4 2018, 6:09 AM

Revision Contents
Changeset List

			Path
A	M		source/_static/css/_icons.scss (63 lines)
M			source/_static/css/breeze.css (49 lines)
A	M	(bin)	source/_static/css/icons.eot
A	M		source/_static/css/icons.svg (47 lines)
A	M	(bin)	source/_static/css/icons.ttf
A	M	(bin)	source/_static/css/icons.woff
A	M	(bin)	source/_static/css/icons.woff2
M			source/conf.py (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	30630	6ec1935		Mar 26 2018, 1:53 PM	★	★
Diff 2	30695	6ec1935	- Changed licence to CC-BY-SA 4.0 like the current HIG is licenced	Mar 27 2018, 7:15 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
1498e4ee8f3f	c97d76700b4f	666f002b73e1	Fabian Riethmayer	Changed licence to CC-BY-SA 4.0 like the current HIG is licenced	Mar 27 2018, 7:15 AM
666f002b73e1	1ae92f1d18cd	6ec1935e5445	Fabian Riethmayer	added kde logo instead of the home button, improved button layout (Show More…)	Mar 26 2018, 1:29 PM