Differential D11714

Fix thumbnail bar update after editing a viewed image
ClosedPublic
Actions

Authored by muhlenpfordt on Mar 26 2018, 1:16 PM.

Details

Reviewers

rkflx

Group Reviewers

Gwenview

Commits

R260:e359ebf19374: Fix thumbnail bar update after editing a viewed image

Summary

After editing an image (e.g. rotate) a new thumbnail is created but
it is not repainted in the View Mode thumbnail bar.
The custom signals documentChanged and busyStateChanged provide
a QModelIndex for the modified document but this is based on the
source model and cannot be used in ThumbnailBarView where the list
view is based on a filtered proxy model and the index is wrong or
does not exist in some cases.
This patch uses the QUrl as argument for both signals and gets the
proper index for the current model in the receiver view.

FIXED-IN: 18.04.0

Test Plan

Open image in Gwenview View Mode
Enable thumbnail bar (Ctrl+B)
Edit image (e.g. rotate with Ctrl+R)
Edit a second time (same or another image)
Thumbnail should always correspond to edited image

Diff Detail

Repository

R260 Gwenview

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

muhlenpfordt requested review of this revision.Mar 26 2018, 1:16 PM

muhlenpfordt created this revision.

muhlenpfordt added a dependent revision: D11715: Fix thumbnail update after undo.Mar 26 2018, 1:19 PM

Updating the thumbnail after the first edit is a side effect of the appearing save bar and therefore changing the view geometry.
In Browse Mode the provided QModelIndex and thumbail update is correct since the base model is used here.
In fullscreen mode all visible thumbnails in the autohide bar are repainted after the image view is updated so this problem is not noticeable here.

Patch works well for me.
I'll leave code review for a more experienced dev, though I can't see any obvious issues with it.

I also noticed this problem quite often (there is no Bugzilla entry though, just checked). Thanks for the patch and sorry for the wait! Nice analysis, makes sense to me.

No issues found when testing, and patch LGTM. The very long signal-slot chain is a bit weird, but I see no good way to make it simpler, so I guess this is fine.

I'd say this patch and the dependent patch can go to stable, either now for 18.04.0 or later for 18.04.1.

This revision is now accepted and ready to land.Apr 7 2018, 10:40 PM

Rebase to Applications/18.04

Closed by commit R260:e359ebf19374: Fix thumbnail bar update after editing a viewed image (authored by muhlenpfordt). · Explain WhyApr 8 2018, 12:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			app/documentinfoprovider.h (4 lines)
M			app/documentinfoprovider.cpp (27 lines)
M			lib/thumbnailview/abstractdocumentinfoprovider.h (4 lines)
M			lib/thumbnailview/thumbnailview.h (8 lines)
M			lib/thumbnailview/thumbnailview.cpp (33 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	30623	880f489		Mar 26 2018, 1:16 PM	★	★
Diff 2	31660	a7819f6	Rebase to Applications/18.04	Apr 8 2018, 12:25 PM	★	★
Diff 3	31661	a7819f6	R260:e359ebf1937420ba9f3be6a961e3fac552250cb6	Apr 8 2018, 12:26 PM	★	★