Differential D11704

Fix right/bottom edge jump issue when adjust rect
ClosedPublic
Actions

Authored by guotao on Mar 26 2018, 4:05 AM.

Details

Reviewers
rkflx
ngraham
Group Reviewers
Spectacle
Commits
R166:b50dc9514f1a: Merge remote-tracking branch 'origin/Applications/18.04'
R166:47312df6c488: Fix right/bottom edge jump issue when adjust rect
Summary

right/bottom edge move unexpected when adjust left/top edge.
To fix this issue, just set x/y before width/height

Test Plan
  1. select a rect, make sure the right/bottom edge is beside moniter edge
  2. drag the topleft, top, top right up or drage top left, left, bottom left to left quickly, the bottom/ right edge move unexpected

Diff Detail

Repository
R166 Spectacle
Branch
bug3
Lint
No Linters Available
Unit
No Unit Test Coverage
guotao requested review of this revision.Mar 26 2018, 4:05 AM
guotao created this revision.
guotao updated this revision to Diff 30583.Mar 26 2018, 4:09 AM

Update diff

ngraham accepted this revision.Mar 26 2018, 1:21 PM
ngraham added a reviewer: Spectacle.

Thanks for the patch. Code looks sane, it fixes the described issue, and I could not cause any regressions after a lot of rectangular region selections on other screen edged and in the middle of the screen.

This revision is now accepted and ready to land.Mar 26 2018, 1:21 PM
rkflx accepted this revision.Mar 26 2018, 8:35 PM

Thanks! Having this in a separate patch is clearly less confusing, I now see what problem you were referring to… Patch LGTM (and you even used Arcanist, which makes for easier review and landing ;)

Closed by commit R166:47312df6c488: Fix right/bottom edge jump issue when adjust rect (authored by guotao, committed by rkflx). · Explain WhyMar 26 2018, 8:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30581

View Options

src/QuickEditor/SelectionRectangle.qml

Loading...