Differential D11674

use shared code for searching for cover
ClosedPublic
Actions

Authored by astippich on Mar 25 2018, 9:52 AM.

Details

Reviewers
mgallien
Group Reviewers
Elisa
Commits
R255:99faf73201b7: use shared code for searching for cover
Summary

cover is search twice for the baloo listener. only use the shared code

Test Plan

delete database and rescan. cover still found correctly

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich requested review of this revision.Mar 25 2018, 9:52 AM
astippich created this revision.
mgallien added a comment.Apr 12 2018, 4:16 PM

Sorry for the delay. I was pretty sure that I had accepted it. This may be frustrating for you.

Could you remove the d->mAllAlbumCover variable in LocalBalooFileListingPrivate ?

Apart from that, a very good catch. Thanks a lot.

mgallien requested changes to this revision.Apr 12 2018, 4:16 PM
This revision now requires changes to proceed.Apr 12 2018, 4:16 PM
mgallien added a comment.Apr 12 2018, 4:16 PM

Sorry for the delay. I was pretty sure that I had accepted it. This may be frustrating for you.

Could you remove the d->mAllAlbumCover variable in LocalBalooFileListingPrivate ?

Apart from that, a very good catch. Thanks a lot.

mgallien accepted this revision.Apr 12 2018, 4:16 PM

Sorry

This revision is now accepted and ready to land.Apr 12 2018, 4:16 PM
Closed by commit R255:99faf73201b7: use shared code for searching for cover (authored by astippich). · Explain WhyApr 12 2018, 5:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/baloo/localbaloofilelisting.cpp (14 lines)

Diff 31980

View Options

src/baloo/localbaloofilelisting.cpp

Loading...