Differential D11673

implement shortcut to toggle filter view
ClosedPublic
Actions

Authored by astippich on Mar 25 2018, 9:49 AM.

Details

Reviewers

mgallien

Group Reviewers

Elisa

Commits

R255:17edcbf3b1b6: implement shortcut to toggle filter view

Summary

use the shortcut as in dolphin to toggle the filter view. also simplifies the implementation a bit and adjust tests

Test Plan

filter view is toggled persistently across all views either with shortcut or button. test passes

Diff Detail

Repository

R255 Elisa

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

astippich requested review of this revision.Mar 25 2018, 9:49 AM

astippich created this revision.

Thanks, this is a nice idea.
You have a type on the title.
Could you also add a test using keyboard and triggering the action shortcut ? It looks missing to me (I may be wrong here).

mgallien requested changes to this revision.Mar 27 2018, 8:45 PM

This revision now requires changes to proceed.Mar 27 2018, 8:45 PM

The state of the view is only controlled by a property binding to an external variable. This is already tested with the tests. The code for setting this variable via a shortcut is in the main qml file and cannot be tested here.

astippich retitled this revision from implememt shortcut to toggle filter view to implement shortcut to toggle filter view.Mar 28 2018, 5:30 PM

ping

Thanks. Unfortunately, I will have very few available time the next few days.

This revision is now accepted and ready to land.Apr 15 2018, 10:38 AM

Closed by commit R255:17edcbf3b1b6: implement shortcut to toggle filter view (authored by astippich). · Explain WhyApr 16 2018, 5:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/qmltests/tst_NavigationActionBar.qml (30 lines)
M			src/elisaapplication.h (2 lines)
M			src/elisaapplication.cpp (7 lines)
M			src/qml/ContentView.qml (35 lines)
M			src/qml/ElisaMainWindow.qml (14 lines)
M			src/qml/GridBrowserView.qml (6 lines)
M			src/qml/MediaAlbumView.qml (6 lines)
M			src/qml/MediaAllTracksView.qml (6 lines)
M			src/qml/NavigationActionBar.qml (17 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	30480	54beb24		Mar 25 2018, 9:49 AM	★	★
Diff 2	32312	c3481ab	R255:17edcbf3b1b6ca11f17d68332ba6a4353dac752e	Apr 16 2018, 5:31 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
b379804db5e1	3e853042efe1	a72a75093834	Alexander Stippich	adjust tests	Mar 24 2018, 5:07 PM
a72a75093834	1ac0c158ed56	54beb2400b39	Alexander Stippich	implememt shortcut to toggle filter view	Mar 24 2018, 4:34 PM