Current color temperature must be applied immediately to hot pluged outputs.
BUG: 391623
broulik |
KWin |
Current color temperature must be applied immediately to hot pluged outputs.
BUG: 391623
Manually. I'm working on auto tests with the new virtual output classes, but
since 5.12.4 will land before I can finish this work, I have to get this fix
in without them.
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
colorcorrection/manager.cpp | ||
---|---|---|
75 | Can't you connect that directly without a lambda? Also, isn't connecting to screenAdded/screenRemoved cleaner? (I don't know but I would expect a screen change to be atomic and the count not neccessarily changing when switching between configurations) |
Just testing info: it works nicely, thanks! :) I'll test further diff updates if there are any.
colorcorrection/manager.cpp | ||
---|---|---|
75 | Seems to also work when connecting hardReset directly and without the lambda. Thanks. There is no screenAdded/screenRemoved signal to my knowledge on this level. That's a structural problem in Screens class. I could connect to the Screen::changed signal. But this is semantically again a stretch. I would ignore it for now. In practice humans are not capable of switching connectors precisely in the same event loop run. |
Thank you for testing!
Can you test the latest revision one more time? But shouldn't make a functional difference.
Can you test the latest revision one more time?
Sure. Tested, still working :). Thanks!