[colorcorrection] Apply current color temperature on screen hot plug
ClosedPublic

Authored by romangg on Mar 24 2018, 6:16 PM.

Details

Summary

Current color temperature must be applied immediately to hot pluged outputs.

BUG: 391623

Test Plan

Manually. I'm working on auto tests with the new virtual output classes, but
since 5.12.4 will land before I can finish this work, I have to get this fix
in without them.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Mar 24 2018, 6:16 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 24 2018, 6:16 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
romangg requested review of this revision.Mar 24 2018, 6:16 PM
broulik added inline comments.
colorcorrection/manager.cpp
75

Can't you connect that directly without a lambda? Also, isn't connecting to screenAdded/screenRemoved cleaner? (I don't know but I would expect a screen change to be atomic and the count not neccessarily changing when switching between configurations)

Just testing info: it works nicely, thanks! :) I'll test further diff updates if there are any.

romangg added inline comments.Mar 26 2018, 9:44 AM
colorcorrection/manager.cpp
75

Seems to also work when connecting hardReset directly and without the lambda. Thanks.

There is no screenAdded/screenRemoved signal to my knowledge on this level. That's a structural problem in Screens class. I could connect to the Screen::changed signal. But this is semantically again a stretch.

I would ignore it for now. In practice humans are not capable of switching connectors precisely in the same event loop run.

romangg updated this revision to Diff 30614.Mar 26 2018, 10:54 AM
  • Connect to hardReset without lambda

Just testing info: it works nicely, thanks! :) I'll test further diff updates if there are any.

Thank you for testing!

Can you test the latest revision one more time? But shouldn't make a functional difference.

Can you test the latest revision one more time?

Sure. Tested, still working :). Thanks!

broulik accepted this revision.Mar 27 2018, 7:22 AM
This revision is now accepted and ready to land.Mar 27 2018, 7:22 AM
This revision was automatically updated to reflect the committed changes.