Differential D11652

Don't show the background if Button.flat
ClosedPublic
Actions

Authored by apol on Mar 24 2018, 5:28 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R242:49ef90bcb985: Don't show the background if Button.flat
Summary

Otherwise the flat property is ignored

Test Plan

Tested on KDE Connect port to use PlasmaComponents

Diff Detail

Repository
R242 Plasma Framework (Library)
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Mar 24 2018, 5:28 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 24 2018, 5:28 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
apol requested review of this revision.Mar 24 2018, 5:28 PM
mart added a subscriber: mart.Apr 3 2018, 10:48 AM

how does it look when the mouse is over the toolbutton?
the plasma button svg also has an element for that, to look like breeze toolbuttons (look at the navigation controls for the calendar for instance

apol updated this revision to Diff 31309.Apr 4 2018, 4:46 PM

Now both Button {flat: true} and ToolButton look the same

mart accepted this revision.Apr 17 2018, 11:44 AM
This revision is now accepted and ready to land.Apr 17 2018, 11:44 AM
Closed by commit R242:49ef90bcb985: Don't show the background if Button.flat (authored by apol). · Explain WhyApr 17 2018, 11:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31309

View Options

src/declarativeimports/plasmacomponents3/Button.qml

Loading...
View Options

tests/buttons_pc3.0.qml

Loading...