Fix pixelated icon scaling for HiDPI screens
ClosedPublic

Authored by acrouthamel on Mar 24 2018, 4:04 AM.

Details

Summary

This enables HiDPI pixmaps in the main window. This commit also replaces QPixmap and KIconLoader with QIcon to load properly scaled icons in the tree menu for HiDPI screens.

BUG: 390737

Before:

After:

Test Plan

Open icon selection in main window.
Expand tree menu and ensure selection works.

Diff Detail

Repository
R103 KMenu Editor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
acrouthamel created this revision.Mar 24 2018, 4:04 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 24 2018, 4:04 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
acrouthamel requested review of this revision.Mar 24 2018, 4:04 AM
acrouthamel retitled this revision from Fixes pixelated icon scaling for HiDPI screens This enables HiDPI pixmaps in the main window. This commit also replaces QPixmap and KIconLoader with QIcon to load properly scaled icons in the tree menu for HiDPI screens. to Fixes pixelated icon scaling for HiDPI screens.Mar 24 2018, 4:09 AM
acrouthamel edited the summary of this revision. (Show Details)
acrouthamel edited the test plan for this revision. (Show Details)
acrouthamel added reviewers: rkflx, broulik.
acrouthamel added a subscriber: ngraham.
cfeck added a subscriber: cfeck.Mar 24 2018, 6:48 AM

Does it still need KIconThemes framework elsewhere? If not, the dependency could be removed.

davidedmundson accepted this revision.Mar 24 2018, 7:20 AM
davidedmundson added a subscriber: davidedmundson.

thanks

This revision is now accepted and ready to land.Mar 24 2018, 7:20 AM
rkflx accepted this revision.Mar 24 2018, 10:55 AM

@acrouthamel Awesome, you made it!

Does it still need KIconThemes framework elsewhere? If not, the dependency could be removed.

E.g. KIconLoader is used elsewhere, so we'll have to keep the dependency for now.

rkflx retitled this revision from Fixes pixelated icon scaling for HiDPI screens to Fix pixelated icon scaling for HiDPI screens.Mar 24 2018, 10:55 AM
This revision was automatically updated to reflect the committed changes.

@acrouthamel Awesome, you made it!

Thanks to you and @broulik :)