Because set jump back and jump back are not in specialbookmarks right clicking on them just closes the menu. This patch fixes that.
Details
Details
- Reviewers
nmel martinkostolny - Group Reviewers
Krusader - Commits
- R167:d17d5fb4ddf1: Add back Jump Back actions to special bookmarks
Test right clicking on set jump back and jump back
Diff Detail
Diff Detail
- Repository
- R167 Krusader
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
This patch should be applied on top of bookmark-quicksearch branch.
right clicking on them just closes the menu
Right click actually executes the action currently. I think this is standard behavior for menus.
This is arguable if these actions should be considered as special bookmarks. On one hand, they are not bookmarks, especially Set Jump Back. On the other hand, right click menu on Trash has Jump Back checkbox, so it's natural to support right click here, and Manage Bookmarks is currently a special bookmark... In addition, I understand that this patch is intended to help with D11624, however D11624 can be implemented cleanly without this one, so let's try to think independently.
Adding other devs to collect opinions. I'm accepting because it seems to be beneficial to have the actions in a special bookmark list.
Comment Actions
right clicking on them just closes the menu
Right click actually executes the action currently. I think this is standard behavior for menus.
It didn't use to be standard behaviour for this menu, it used to be that right clicking on them you got the same options as you get when right clicking on trash et al. AFIK it's not consistent with other menus either. The only menu I could find where right clicking doesn't give you a pop up is "Useractions" and there right clicking simply does nothing. I could find no menus where right clicking executes the action, nor would a user expect right clicking to trigger the action.
This is arguable if these actions should be considered as special bookmarks. On one hand, they are not bookmarks, especially Set Jump Back. On the other hand, right click menu on Trash has Jump Back checkbox, so it's natural to support right click here, and Manage Bookmarks is currently a special bookmark...
They used to be special bookmarks before the code for 'set jump back' was changed.
In addition, I understand that this patch is intended to help with D11624
Not really that patch is trivial to implement with or without 'set jump back' in special bookmarks.
Comment Actions
Oh, that's right. It appears I've removed the code in f515bfa and we haven't noticed before. Thanks for the fix! I'll apply it to the branch then.