| sitter | |
| fvogt |
Openssl fix deprecation warnings
Removed unused function: X509_SIG_getm
deprecated warnings for:
ASN1_STRING_data
DSA_generate_parameters
RSA_generate_key
RAND_pseudo_bytes
Tested with openssl-1.0.2l on ubuntu:14.04
Deprecation warning spotted with openssl-1.1.0.g-1
one deprecation warning left: TLSv1_client_method
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Looks good to me otherwise.
| plugins/qca-ossl/qca-ossl.cpp | ||
|---|---|---|
| 544 | ossl110-compat.h is for this purpose. | |
Looks good to me, except for the unnecessary checks for nullptr.
| plugins/qca-ossl/qca-ossl.cpp | ||
|---|---|---|
| 1842 | Useless nullptr checks? | |
| plugins/qca-ossl/qca-ossl.cpp | ||
|---|---|---|
| 1842 | It is copypasted from QScopedPointerPodDeleter SO claims that free(NULL) is noop, https://stackoverflow.com/questions/1912325/checking-for-null-before-calling-free I will remove checks | |
| plugins/qca-ossl/qca-ossl.cpp | ||
|---|---|---|
| 1842 | If this method can get invoked with nullptr, they are necessary. RSA_free(nullptr) is not a noop. | |