Differential D11596

Add support for dynamic visibility
ClosedPublic
Actions

Authored by aheinecke on Mar 23 2018, 7:18 AM.

Details

Reviewers
aacid
Group Reviewers
Okular
Maniphest Tasks
T8274: Support for PDF form visibility changes
Commits
R223:bf90867c13ed: Add support for dynamic visibility
Summary

This adds the hidden property to JavaScript fields and
uses it to implement support for HideAction.

Test Plan

Unit test in the next commit.

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aheinecke requested review of this revision.Mar 23 2018, 7:18 AM
aheinecke created this revision.
aheinecke updated this revision to Diff 31736.Apr 9 2018, 1:14 PM

Changed from single targetName to QVector targets API

aacid added a subscriber: aacid.Apr 16 2018, 9:41 PM
aacid added inline comments.
generators/poppler/generator_pdf.cpp
459

I understand why you're going through javascript for this, it kind of makes it a bit easier for you since you don't have to define a new linkaction type in okular, but i am not convinced it's the best solution, let me sleep on it.

aacid accepted this revision.Apr 23 2018, 9:55 PM

ok, i guess

This revision is now accepted and ready to land.Apr 23 2018, 9:55 PM
Closed by commit R223:bf90867c13ed: Add support for dynamic visibility (authored by aheinecke, committed by aacid). · Explain WhyApr 23 2018, 9:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32922

View Options

core/form.h

Loading...
View Options

core/form.cpp

Loading...
View Options

core/script/kjs_field.cpp

Loading...
View Options

generators/poppler/CMakeLists.txt

Loading...
View Options

generators/poppler/formfields.h

Loading...
View Options

generators/poppler/formfields.cpp

Loading...
View Options

generators/poppler/generator_pdf.cpp

Loading...