Details

Reviewers

tcanabrava
patrickelectric
laysrodrigues

Commits

R232:531c6b84b3e3: New: Temperature Widget
R232:2ca32b634daa: New: PrintWidget
R232:34488302267e: New: StatusWidget
R232:67a50db01c43: New: MovementWidget
R232:6a3a1cd5cbb2: New: SdWidget
R232:c0159c2ea552: Clean up the testClient
R232:5e629f1d7415: New: Command widget
R232:73dce69c29de: New: LogWidget

Summary

Clean up the testClient by placing most of the ui into its own objects.

New: CommandWidget
New: PrintWidget
New: LogWidget
New: StatusWidget
New: MovementWidget
New: Temperature Widget
New: SdWidget

Test Plan

MoreTesting is always good.

Diff Detail

Repository

R232 AtCore

Branch

widgets

Lint

No Linters Available

Unit

No Unit Test Coverage

rizzitello requested review of this revision.Mar 22 2018, 7:51 PM

rizzitello created this revision.

few fixes

laysrodrigues requested changes to this revision.Mar 25 2018, 9:10 PM

laysrodrigues added inline comments.

testclient/widgets/statuswidget.h
22	headers in alphabetical order

This revision now requires changes to proceed.Mar 25 2018, 9:10 PM

lays suggestion

rizzitello marked an inline comment as done.Mar 25 2018, 10:52 PM

laysrodrigues requested changes to this revision.Mar 26 2018, 12:21 AM

laysrodrigues added inline comments.

testclient/mainwindow.h
34	headers in alphabetical order sd before st (sorry for missing this one)

This revision now requires changes to proceed.Mar 26 2018, 12:21 AM

New: SdWidget

rizzitello marked an inline comment as done.Mar 26 2018, 3:28 AM

tcanabrava added inline comments.Mar 26 2018, 10:48 AM

testclient/widgets/temperaturewidget.cpp
84	don't pass by references integers. https://www.macieira.org/blog/2012/02/the-value-of-passing-by-value/
91	no int by ref.
testclient/widgets/temperaturewidget.h
40–42	don't pass by ref integers.

rizzitello marked 3 inline comments as done.Mar 26 2018, 7:40 PM

Remove int referances

Safer lambdas

rebase

laysrodrigues accepted this revision.Mar 27 2018, 2:58 AM

This revision is now accepted and ready to land.Mar 27 2018, 2:58 AM

rizzitello closed this revision.Mar 27 2018, 7:52 PM

		Path
M		testclient/mainwindow.h (211 lines)
M		testclient/mainwindow.cpp (654 lines)
M		testclient/widgets/CMakeLists.txt (11 lines)
A	M	testclient/widgets/commandwidget.h (41 lines)
A	M	testclient/widgets/commandwidget.cpp (70 lines)
A	M	testclient/widgets/logwidget.h (85 lines)
A	M	testclient/widgets/logwidget.cpp (102 lines)
A	M	testclient/widgets/movementwidget.h (47 lines)
A	M	testclient/widgets/movementwidget.cpp (95 lines)
A	M	testclient/widgets/printwidget.h (49 lines)
A	M	testclient/widgets/printwidget.cpp (98 lines)
A	M	testclient/widgets/sdwidget.h (41 lines)
A	M	testclient/widgets/sdwidget.cpp (66 lines)
A	M	testclient/widgets/statuswidget.h (55 lines)
A	M	testclient/widgets/statuswidget.cpp (110 lines)
A	M	testclient/widgets/temperaturewidget.h (50 lines)
A	M	testclient/widgets/temperaturewidget.cpp (95 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	30246	37e951d		Mar 22 2018, 7:51 PM	★	★
Diff 2	30247	37e951d	few fixes	Mar 22 2018, 8:02 PM	★	★
Diff 3	30568	37e951d	- lays suggestion	Mar 25 2018, 10:52 PM	★	★
Diff 4	30580	37e951d	- New: SdWidget	Mar 26 2018, 3:28 AM	★	★
Diff 5	30655	37e951d	- Remove int referances	Mar 26 2018, 7:41 PM	★	★
Diff 6	30662	37e951d	- Safer lambdas	Mar 26 2018, 8:59 PM	★	★
Diff 7	30664	068b46c	- rebase	Mar 26 2018, 9:21 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
6a3a1cd5cbb2	373347542dd5	531c6b84b3e3	Chris Rizzitello	New: SdWidget (Show More…)	Mar 22 2018, 4:00 AM
531c6b84b3e3	90823ccc96ff	67a50db01c43	Chris Rizzitello	New: Temperature Widget (Show More…)	Mar 22 2018, 3:21 AM
67a50db01c43	92dfa650f13d	34488302267e	Chris Rizzitello	New: MovementWidget (Show More…)	Mar 22 2018, 2:23 AM
34488302267e	a5aa91b5f384	73dce69c29de	Chris Rizzitello	New: StatusWidget (Show More…)	Mar 22 2018, 12:34 AM
73dce69c29de	4d5b70308cc1	2ca32b634daa	Chris Rizzitello	New: LogWidget (Show More…)	Mar 21 2018, 10:29 PM
2ca32b634daa	3e4b24dd8374	5e629f1d7415	Chris Rizzitello	New: PrintWidget (Show More…)	Mar 21 2018, 9:15 PM
5e629f1d7415	d532409e1394	068b46c8205e	Chris Rizzitello	New: Command widget (Show More…)	Mar 21 2018, 8:38 PM

Clean up the testClient
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 30664

testclient/mainwindow.h

testclient/mainwindow.cpp

testclient/widgets/CMakeLists.txt

testclient/widgets/commandwidget.h

testclient/widgets/commandwidget.cpp

testclient/widgets/logwidget.h

testclient/widgets/logwidget.cpp

testclient/widgets/movementwidget.h

testclient/widgets/movementwidget.cpp

testclient/widgets/printwidget.h

testclient/widgets/printwidget.cpp

testclient/widgets/sdwidget.h

testclient/widgets/sdwidget.cpp

testclient/widgets/statuswidget.h

testclient/widgets/statuswidget.cpp

testclient/widgets/temperaturewidget.h

testclient/widgets/temperaturewidget.cpp

Clean up the testClientClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 30664

testclient/mainwindow.h

testclient/mainwindow.cpp

testclient/widgets/CMakeLists.txt

testclient/widgets/commandwidget.h

testclient/widgets/commandwidget.cpp

testclient/widgets/logwidget.h

testclient/widgets/logwidget.cpp

testclient/widgets/movementwidget.h

testclient/widgets/movementwidget.cpp

testclient/widgets/printwidget.h

testclient/widgets/printwidget.cpp

testclient/widgets/sdwidget.h

testclient/widgets/sdwidget.cpp

testclient/widgets/statuswidget.h

testclient/widgets/statuswidget.cpp

testclient/widgets/temperaturewidget.h

testclient/widgets/temperaturewidget.cpp

Clean up the testClient
ClosedPublic
Actions

Revision Contents
Changeset List