[AppMenu] Ignore show request when application menu isn't configured
ClosedPublic

Authored by broulik on Mar 22 2018, 2:28 PM.

Details

Summary

Before Plasma 5.12 one could only have either global menu or decoration button configured but since the setting was non-intuitive it was switched to auto-enable when applet or button is present.
This results in both menus reacting to e.g. Alt+F for File menu.

BUG: 392012
FIXED-IN: 5.12.4

Test Plan
  • Removed title bar menu button, Alt+F only triggered global menu
  • Button still worked if configured

You still get the issue of double menu when both are configured but that is independent from this clear bug fix

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 22 2018, 2:28 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 22 2018, 2:28 PM
Restricted Application added subscribers: KWin, kwin. · View Herald Transcript
broulik requested review of this revision.Mar 22 2018, 2:28 PM
mart added a subscriber: mart.Mar 23 2018, 12:58 PM

in this way alt+f will never work in the in-decoration menu?

in this way alt+f will never work in the in-decoration menu?

Of course it will work but only if you have it actually added to your title bar. This patch is about not showing it when the decoration button isn't there, when you just use global menu applet.

mart accepted this revision.Mar 23 2018, 1:11 PM
This revision is now accepted and ready to land.Mar 23 2018, 1:11 PM
This revision was automatically updated to reflect the committed changes.