Fix off by 1 error
AbandonedPublic

Authored by kfunk on Mar 16 2016, 6:22 PM.

Details

Reviewers
parolanilsson

Diff Detail

Repository
R60 KDevelop Krazy2
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
parolanilsson retitled this revision from to Fix off by 1 error.
parolanilsson updated this object.
parolanilsson edited the test plan for this revision. (Show Details)
parolanilsson added a reviewer: kfunk.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMar 16 2016, 6:22 PM
kfunk edited edge metadata.Mar 16 2016, 7:17 PM

Does that fix issues in the unit test? If yes => go for it, otherwise please add an unit test if possible.

If you want to work on kdev-krazy, please try to get the unit tests working. That would be awesome.
For me they fail unrelated to whether krazy2 is installed or not. Both cases should "work", i.e. the test run should succeed.

Also see: https://build.kde.org/view/Kdevelop/job/kdev-krazy2%20master%20kf5-qt5/18/PLATFORM=Linux,compiler=gcc/testReport/junit/(root)/TestSuite/analysisjobtest/

I saw that detected problems was off by one line.
When working on kdec-cppcheck I saw that KDevelop::DocumentRange seems to be 0-based while the result from Krazy2 is 1-based.

I now realize I changed the wrong location.
I will also need to update all tests checking line number.
I'll keep looking into this.

kfunk requested changes to this revision.Mar 17 2016, 10:01 PM
kfunk edited edge metadata.
This revision now requires changes to proceed.Mar 17 2016, 10:01 PM
kfunk added a comment.Apr 8 2016, 1:11 PM

Please create another patch, closing this one.

kfunk commandeered this revision.Apr 8 2016, 1:12 PM
kfunk abandoned this revision.
kfunk edited reviewers, added: parolanilsson; removed: kfunk.