[Battery Monitor] Support "Gaming Input Battery type"
ClosedPublic

Authored by broulik on Mar 22 2018, 7:51 AM.

Details

Summary

Gives them a nicer icon.
The icon does not yet exist in Plasma but gaming-input does, so it falls back to that.

Test Plan

Depends on D11570

I think this stuff (sans the soliddeviceengine i18n) could also go into 5.12 since it's trivial and Frameworks that suddenly supports those devices is independent of Plasma it cannot as it requires a dependency bump for the new enum, unless we want to use magic ints again

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 22 2018, 7:51 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 22 2018, 7:51 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 22 2018, 7:51 AM
broulik edited the test plan for this revision. (Show Details)Mar 22 2018, 7:59 AM
broulik edited reviewers, added: lbeltrame; removed: fvogt.Mar 22 2018, 8:03 AM
anthonyfieroni added a subscriber: anthonyfieroni.EditedMar 22 2018, 8:23 AM

@broulik, does it makes sens, when batteries isn't available (as your screenshot) to be shown, the icon and its percentage of next device in the list, in systray ?

@broulik, does it makes sens, when batteries isn't available (as your screenshot) to be shown, the icon and its percentage of next device in the list, in systray ?

I thought about that a long time and I think we even used to show the lowest peripheral battery, if any, but it wasn't particularly predictable what it shows, so I removed it. Could be revisited at some point but that is unrelated to this patch

davidedmundson accepted this revision.Mar 23 2018, 1:17 AM
This revision is now accepted and ready to land.Mar 23 2018, 1:17 AM
broulik edited the test plan for this revision. (Show Details)Mar 23 2018, 8:39 AM
This revision was automatically updated to reflect the committed changes.