Differential D11567

Fix use of assert/crash when removing global shortcut
ClosedPublic
Actions

Authored by davidedmundson on Mar 22 2018, 2:05 AM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R119:db311474f048: Fix use of assert/crash when removing global shortcut
Summary

I'm not the author, but it's pretty clear what the intention was.

We expect to get one result back from proxyModel->match
We use results.first(), so we want to check we have at least one entry.
The assert was written backwards

BUG: 387444

Test Plan

Can now remove a group without a crash

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Mar 22 2018, 2:05 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 22 2018, 2:05 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Mar 22 2018, 2:05 AM
graesslin accepted this revision.Mar 22 2018, 5:23 AM
graesslin added a subscriber: graesslin.

Or just remove the assert.

This revision is now accepted and ready to land.Mar 22 2018, 5:23 AM
Closed by commit R119:db311474f048: Fix use of assert/crash when removing global shortcut (authored by davidedmundson). · Explain WhyMar 22 2018, 8:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30198

View Options

kcms/keys/kglobalshortcutseditor.cpp

Loading...