| broulik |
A requested feature was to allow a runner to query N services for
results. i.e search through of all any konsole sessions.
Users can now set in the desktop file service=org.whatever.* and all
running services that match that name are queried for actions and
matching results. Only the service that provided the match will have
relevant "Run" method invoked.
Updated unit test
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| src/dbusrunner.cpp | ||
|---|---|---|
| 57–89 | I'd rather not, as it will prevent me from porting away from the deprecated function you mention should Qt ever get argname0 rules support. | |
| 60 | It is in the main thread. But it's only a round trip to the dbus-daemon not a client, so it's blocking in the same way I can make it async, but I don't think we gain too much. | |
| 69 | Yes, but the alternative doesn't exist. Without going too much into DBus match rules (which are awesome), QDBusServiceWatcher connects to the signal serviceOwnerChanged on the org.freedesktop.DBus interface to be notified *only* when either the first or second arguments match the given string. It's why it's a lot better than this deprecated method. DBus does have a concept of saying "match when the argument starts with [blah]", but QtDbus doesn't, it'd require a bit of a refactor to do so. I might try and add it. | |