Change the behaviour of the add layer button
ClosedPublic
Actions

Authored by seorasm on Mar 20 2018, 11:11 AM.

Details

Reviewers

Group Reviewers

Commits

Summary

In the layers docker, if more than 1 layer is selected, then
the add layer button now creates a quick group for the selected
layers.

BUG: 385050

Repository

R37 Krita

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

seorasm requested review of this revision.Mar 20 2018, 11:11 AM

Haven't tested but looks fine to me.
Though there are some minor issues with the code formatting:

one space between if and the open parenthesis
else on the same line as the previous closing bracket
Why even bother with a local variable singleLayer? Just put the condition in the if clause!

I've made the small formatting changes suggested.

Yes, this looks correct now. Can you push it yourself?

This revision is now accepted and ready to land.Mar 28 2018, 9:22 AM

I don't think I can push it, since this is my first patch. I'd need a developer account to push wouldn't I?

Okay. After about three patches, we'll ask you to get a developer account. I'll push this patch. I need your real name for that, though.

Thanks, my name's Seoras Macdonald.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			plugins/dockers/defaultdockers/kis_layer_box.h (2 lines)
M			plugins/dockers/defaultdockers/kis_layer_box.cpp (17 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	29986			Mar 20 2018, 11:05 AM	★	★
Diff 2	30102			Mar 21 2018, 9:07 AM	★	★
Diff 3	32449	4381a51	R37:c7ddbf1a0145d1c9a1fea01778df709c508f7c80	Apr 18 2018, 8:48 AM	★	★