Add a refresh button to the plasmoid
AbandonedPublic

Authored by mtijink on Mar 19 2018, 7:58 PM.

Details

Summary

This adds a refresh button to the plasmoid if no device is connected.

Test Plan

Refreshing works, and the button only appears when no devices are connected.

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mtijink requested review of this revision.Mar 19 2018, 7:58 PM
mtijink created this revision.

Screenshot:

nicolasfella accepted this revision.Mar 19 2018, 10:01 PM
nicolasfella added a subscriber: nicolasfella.

Nice idea! Code looks fine to me

This revision is now accepted and ready to land.Mar 19 2018, 10:01 PM
apol added a subscriber: apol.Mar 19 2018, 11:59 PM

Meh, it's a workaround to a bug. We should investigate the bug, not add UI to fix what we can't fix with code. :P

In D11501#229604, @apol wrote:

Meh, it's a workaround to a bug. We should investigate the bug, not add UI to fix what we can't fix with code. :P

You're right, but currently I'm using kdeconnect-cli --refresh, so this improves the situation a bit.

This revision was automatically updated to reflect the committed changes.
apol added a comment.Mar 21 2018, 12:17 AM

Ugh guys, this is frustrating. Can we discuss things? This is laziness and bad usability in one commit. I really think this should be reverted immediately.

If it's hurting your usability keep a local patch or something, but we can't be taking every shortcut just for the sake of it.

mtijink reopened this revision.Mar 21 2018, 7:56 AM

Sorry, we had a misunderstanding. I thought you didn't especially like it, but was okay with this being merged (for now).

I'll revert once I get home.

Why is this bad useability? If kde connect autoconnects (which is not reliable enough, and we should indeed try to improve that) you won't have the button. Otherwise, why not show something which might help users connect?

This revision is now accepted and ready to land.Mar 21 2018, 7:56 AM
mtijink abandoned this revision.Mar 25 2018, 11:24 AM