Differential D11482

Export Translations to right filename
Needs RevisionPublic
Actions

Authored by leszeklesner on Mar 19 2018, 12:54 PM.

Details

Reviewers
broulik
mart
ivan
davidedmundson
Summary

It exports its qml translations to plasmavault-kde.pot but plasma expects it to be plasma_applet_org.kde.plasma.vault.pot

Diff Detail

Repository
R845 Plasma Vault
Lint
Lint Skipped
Unit
Unit Tests Skipped
leszeklesner created this revision.Mar 19 2018, 12:54 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 19 2018, 12:54 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
leszeklesner requested review of this revision.Mar 19 2018, 12:54 PM
mart accepted this revision.Mar 19 2018, 2:13 PM
This revision is now accepted and ready to land.Mar 19 2018, 2:13 PM
ivan accepted this revision.Mar 19 2018, 6:05 PM
lueck added a subscriber: lueck.Mar 20 2018, 1:52 PM

I doubt changing the name of the translation catalog is correct, because

  1. CMakeLists.txt has add_definitions (-DTRANSLATION_DOMAIN=\"plasmavault-kde\") therefore the vault library uses the translation domain "plasmavault-kde", not "plasma_applet_org.kde.plasma.vault"
  2. the qml files use i18nd("plasmavault-kde", foo) calls, i.e. the translation domain "plasmavault-kde" as well
davidedmundson requested changes to this revision.Mar 20 2018, 4:22 PM
davidedmundson added a subscriber: davidedmundson.

I doubt changing the name of the translation catalog is correct, because

You're right. Change could still make sense if done with changing those other things.

Leszek which were the strings that renderered incorrectly?
Have you tried renaming your local .po file to see if it does fix things?

This revision now requires changes to proceed.Mar 20 2018, 4:22 PM
leszeklesner added a comment.EditedMar 20 2018, 4:50 PM
In D11482#229987, @davidedmundson wrote:

...
Leszek which were the strings that renderered incorrectly?
Have you tried renaming your local .po file to see if it does fix things?

The issue actually was with the localization not been completed for some languages. So basically my mistake not looking there first after kbroulik told me it is a bug :P
I initially thought maybe the po files weren't updated correctly and that caused the translations not being complete. But that is wrong apparently.

Revision Contents
Changeset List

PathPackages
MMessages.sh (2 lines)

Diff 29911

View Options

Messages.sh

Loading...