Connect in instance
ClosedPublic

Authored by rizzitello on Mar 19 2018, 2:59 AM.

Details

Summary
  • Connect toolbar for atcore instance
  • closeable tabs if more then one tab open
  • atcore is stoped if a tab is closed.
Test Plan

Apply it with arc. Creating extra instances will fail unless you use the D10786 with this.

Diff Detail

Repository
R231 Atelier
Branch
connectBar
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello requested review of this revision.Mar 19 2018, 2:59 AM
rizzitello created this revision.
patrickelectric requested changes to this revision.Mar 19 2018, 5:06 PM
patrickelectric added inline comments.
src/widgets/atcoreinstancewidget.cpp
175

identantion.

src/widgets/atcoreinstancewidget.h
27

Push before settings.

64

button before toolbar

70

m_

This revision now requires changes to proceed.Mar 19 2018, 5:06 PM
rizzitello marked 4 inline comments as done.Mar 19 2018, 7:48 PM
rizzitello updated this revision to Diff 29942.Mar 19 2018, 7:49 PM
rizzitello edited the test plan for this revision. (Show Details)
  • Patrick's suggestions
laysrodrigues requested changes to this revision.Mar 25 2018, 9:20 PM

Its not compiling because of use of settings instead of m_settings.

src/widgets/atcoreinstancewidget.cpp
460

same on the above lines

This revision now requires changes to proceed.Mar 25 2018, 9:20 PM
  • Fix build
  • Disconnect button is now normal size
rizzitello marked an inline comment as done.Mar 25 2018, 11:07 PM
laysrodrigues accepted this revision.Mar 26 2018, 12:27 AM
tcanabrava added inline comments.Mar 26 2018, 10:52 AM
src/mainwindow.cpp
46

why you are capturing everything by reference if there's not everything there? capture [this].

47–48

that's weird.

src/widgets/atcoreinstancewidget.cpp
451–453

no need to test the if.
if the list is empty, the call to addItems will not add anything.

rizzitello marked 3 inline comments as done.Mar 26 2018, 11:15 AM
rizzitello added inline comments.
src/mainwindow.cpp
46

In this case [&] and [this] should capture the same "this" referance.

47–48

Thats how you correctly quit a tab. calling QTabWidget::remove only removes the tab from the view it does not delete it. We want ours removed instances to be completely closed if removed.

src/widgets/atcoreinstancewidget.cpp
451–453

Im sure you have heard the expression

better safe then sorry

I will double check this is safe and remove the check .

rizzitello updated this revision to Diff 30656.Mar 26 2018, 7:48 PM
rizzitello marked 3 inline comments as done.
  • tomaz suggestions
rizzitello marked an inline comment as done.Mar 26 2018, 7:48 PM
rizzitello marked 2 inline comments as done.
patrickelectric accepted this revision.Mar 27 2018, 8:51 PM

This file was deleted.

This revision is now accepted and ready to land.Mar 27 2018, 8:51 PM
laysrodrigues accepted this revision.Mar 27 2018, 9:11 PM
rizzitello closed this revision.Mar 28 2018, 8:06 PM