Differential D11467

use a proper slot to trigger pause from mpris2 interface
ClosedPublic
Actions

Authored by mgallien on Mar 18 2018, 9:51 PM.

Details

Reviewers
astippich
Group Reviewers
Elisa
Commits
R255:dc6a11603f52: use a proper slot to trigger pause from mpris2 interface
Summary

use a proper slot to trigger pause from mpris2 interface

Test Plan

play and pause through mpris2 works as intended

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien requested review of this revision.Mar 18 2018, 9:51 PM
mgallien created this revision.
broulik added a subscriber: broulik.Mar 19 2018, 6:58 AM
broulik added inline comments.
src/manageaudioplayer.cpp
330

MPris Pause should just Pause not PlayPause

mgallien marked an inline comment as done.Mar 19 2018, 7:43 AM
mgallien added inline comments.
src/manageaudioplayer.cpp
330

It will only trigger pause and change the mPlayingState variable, if it is playing.

This way, it should have the correct behavior with respect to the mpris2 interface.

astippich accepted this revision.Mar 19 2018, 7:43 PM
This revision is now accepted and ready to land.Mar 19 2018, 7:43 PM
mgallien updated this revision to Diff 29968.Mar 20 2018, 7:02 AM
mgallien marked an inline comment as done.
  • simplify the ManageAudioPlayer::ensurePlay and ensurePause slots
Closed by commit R255:dc6a11603f52: use a proper slot to trigger pause from mpris2 interface (authored by mgallien). · Explain WhyMar 20 2018, 9:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30052

View Options

src/manageaudioplayer.h

Loading...
View Options

src/manageaudioplayer.cpp

Loading...
View Options

src/mpris2/mediaplayer2player.cpp

Loading...