The current code fails to build on Mac OS X and musl. This revision uses camel-case to avoid using reserved identifiers.
Details
Details
- Reviewers
tleupold - Group Reviewers
KPhotoAlbum
Applied this patch to both master and the current release (5.3).
Built on musl Linux (Adélie), and Mac OS X 10.9. No build failures were exhibited. The software runs correctly.
Diff Detail
Diff Detail
- Repository
- R463 KPhotoAlbum
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
The patch seems to be reasonable to me, but I have to ask a dumb question as I'm new to that Phabricator thing: How can I test it? It doesn't live in git, does it? Can I download a patch that I can apply to a local testing branch?
Edit: Nevermind. I found it ;-) Sorry for the spam …
Comment Actions
So … I just tried to manually commit your patch (I'm pretty sure this can somehow be done automagically through that Phabricator/Arcanist/Whatever widget, but who knows?! ;-) – but I need your (full?) name and an email address, so that I can set the correct author for the commit. I found neither … would you be so kind to tell me (e. g. via IRC at the kphotoalbum channel on freenode? I'm most of the time logged in as l3u there). Thanks :-)