Differential D11408

Include clocale instead of locale.h
ClosedPublic
Actions

Authored by wojnilowicz on Mar 17 2018, 6:04 AM.

Details

Reviewers
tbaumgart
adridg
Group Reviewers
KMyMoney
Commits
R261:ea1fca56fb25: Include clocale instead of locale.h
R261:a42a84b18f60: Include clocale instead of locale.h
Summary

Building KMyMoney on FreeBSD fails here
https://build.kde.org/job/Extragear%20kmymoney%20kf5-qt5%20FreeBSDQt5.9/
and this patch is intended to fix that.

According to
http://en.cppreference.com/w/cpp/locale/localeconv
the function std::localeconv() can be used if "clocale" is included, but in our case "locale.h" is included, which coresponds to plain C language.

I assume that's causing problem on FreeBSD. I didn't test it in real environment.

Diff Detail

Repository
R261 KMyMoney
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
wojnilowicz requested review of this revision.Mar 17 2018, 6:04 AM
wojnilowicz created this revision.
tbaumgart added a reviewer: adridg.Mar 17 2018, 6:24 AM

I added a knowledgeable reviewer. Maybe, he can share some of his wisdom.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 18 2018, 9:42 AM
Closed by commit R261:ea1fca56fb25: Include clocale instead of locale.h (authored by wojnilowicz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29815

View Options

kmymoney/misc/platformtools_gnu.cpp

Loading...