Article viewer: Reset scroll position when loading a new article
ClosedPublic

Authored by marten on Mar 16 2018, 11:33 AM.

Details

Summary

This is the fix for the article viewer not scrolling back to the top when loading a new article, as suggested in https://bugs.kde.org/show_bug.cgi?id=382587 comment 2. In theory this should not be necessary as the article is scrolled to the top via JavaScript, but this does not appear to work in the reported cases.

As an added bonus, this change appears to improve the performance of the application when moving between articles with "Next unread article" or similar, the change happening instantly instead of there being a perceptible delay. However, this is just my subjective observation.

Test Plan

Built akregator with this change, observed that the article viewer is reliably scrolled back to the top when showing a new article.

Diff Detail

Repository
R201 Akregator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
marten created this revision.Mar 16 2018, 11:33 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 16 2018, 11:33 AM
marten requested review of this revision.Mar 16 2018, 11:33 AM
dvratil accepted this revision.Mar 22 2018, 1:39 PM
This revision is now accepted and ready to land.Mar 22 2018, 1:39 PM
Closed by commit R201:84b4da183fb8: Article viewer: Reset scroll position when loading a new article (authored by Patrick NoSurname <patrick@noxs.nl>, committed by marten). · Explain WhyMar 24 2018, 3:10 PM
This revision was automatically updated to reflect the committed changes.