Remove Ui file
ClosedPublic

Authored by rizzitello on Mar 16 2018, 6:55 AM.

Diff Detail

Repository
R232 AtCore
Branch
noUI
Lint
No Linters Available
Unit
No Unit Test Coverage
rizzitello requested review of this revision.Mar 16 2018, 6:55 AM
rizzitello created this revision.
rizzitello edited the summary of this revision. (Show Details)Mar 16 2018, 6:56 AM
rizzitello edited the test plan for this revision. (Show Details)
rizzitello added a project: Atelier: AtCore.
rizzitello added a subscriber: Atelier: AtCore.
rizzitello updated this revision to Diff 29661.Mar 16 2018, 7:00 AM
rizzitello edited the summary of this revision. (Show Details)
rizzitello edited the test plan for this revision. (Show Details)
  • disable sd dock on start up
laysrodrigues requested changes to this revision.Mar 16 2018, 11:41 AM
laysrodrigues added inline comments.
testclient/mainwindow.cpp
45

use tr so we can have translation.

testclient/mainwindow.h
300

use m_variable for private variables.

This revision now requires changes to proceed.Mar 16 2018, 11:41 AM
rizzitello marked 2 inline comments as done.Mar 16 2018, 11:50 AM
rizzitello added inline comments.
testclient/mainwindow.cpp
45

We currenly do not translate the test gui at all
These can be added in another path, this patch is just to remove the UI.

testclient/mainwindow.h
300

AtCore does not use this anywhere in the code base.

rizzitello marked 4 inline comments as done.Mar 16 2018, 12:19 PM
rizzitello added inline comments.
testclient/mainwindow.h
300

My Reasoning on this is as follows.

  1. Not currently used in any AtCore objects.
  2. Not part of the Kde guidelines
  3. Not in our contribution guidelines
patrickelectric requested changes to this revision.Mar 16 2018, 12:57 PM
patrickelectric added inline comments.
testclient/mainwindow.cpp
503

I don't see this as a good thing. Ui files help to improve the interface without changing the code base. Any GOOD motive to remove it ?

rizzitello marked 2 inline comments as done.Mar 16 2018, 1:39 PM
rizzitello added inline comments.
testclient/mainwindow.cpp
503

Some reasons:

  • Removes code spaghettification by making the docks in one place instead of across several files and functions.
  • Despaghettification makes code easier to read.
  • Avoid designers sizing based on the host it was last saved on.
  • Guis made in code are explict. Ui files automaticly add many things to the object like default sizes and other properties we want done at runtime.

This Diff Is Only the first part of the plan to simplify the atcore-gui

  • Moving the docks into their own objects. This will simplity the mainwindow class.
  • Comments for the creation of the docks will be added so its eaiser to follow.
rizzitello marked an inline comment as done.
  • some clean up
  • added tr calls
rizzitello added inline comments.Mar 16 2018, 11:14 PM
testclient/mainwindow.cpp
45

Adding tr calls to this patch

rizzitello marked 3 inline comments as done.Mar 16 2018, 11:14 PM
laysrodrigues accepted this revision.Mar 17 2018, 1:31 AM
patrickelectric accepted this revision.Mar 17 2018, 1:10 PM

The patch appears to be correct, but I don't know if removing the ui file is a good thing after all. @tcanabrava @laysrodrigues what do you think ?

This revision is now accepted and ready to land.Mar 17 2018, 1:10 PM
laysrodrigues accepted this revision.Mar 17 2018, 1:20 PM
tcanabrava accepted this revision.Mar 21 2018, 1:20 PM

I would use ui files for this (too much code just to construct the interface) but I understand that sith hates that. +1.

I plan to move alot of this to other files . Creating a set of widgets that the test client will use

rizzitello closed this revision.Mar 21 2018, 7:56 PM