Don't block evaluating DBus scripts if widgets are locked.
ClosedPublic

Authored by davidedmundson on Mar 16 2018, 2:55 AM.

Details

Summary

Original decision didn't really have a rationale:
https://git.reviewboard.kde.org/r/125648/

It's causing bugs in people doing somewhat sensible things.
BUG: 380347

If widgets are locked, the script will still fail when it tries to do
something it can't.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Mar 16 2018, 2:55 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 16 2018, 2:55 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Mar 16 2018, 2:55 AM

Please change the check to be

if (immutability() == Plasma::Types::SystemImmutable) {
    ...
    return;
}

we don't want to introduce a way to mess up sysadmin-confined setups this way.

mart added a subscriber: mart.Mar 19 2018, 2:52 PM

Please change the check to be

if (immutability() == Plasma::Types::SystemImmutable) {
    ...
    return;
}

we don't want to introduce a way to mess up sysadmin-confined setups this way.

yep, i'm fine with the patch, but systemimmutable should still be... immutable

system immutable check

broulik requested changes to this revision.Mar 20 2018, 4:25 PM

Now you block everything but when system immutable

This revision now requires changes to proceed.Mar 20 2018, 4:25 PM

How embarassing :/

broulik accepted this revision.Mar 20 2018, 4:28 PM
This revision is now accepted and ready to land.Mar 20 2018, 4:28 PM
This revision was automatically updated to reflect the committed changes.
Zren added a subscriber: Zren.Apr 6 2018, 2:44 PM

Um, if (immutability() != Plasma::Types::SystemImmutable) { return; } was pushed.

You're last revision https://phabricator.kde.org/D11375?id=30006 had it correctly. if (immutability() == Plasma::Types::SystemImmutable) { return; }