Differential D11373

Don't rely on playPause for MPRIS pause
ClosedPublic
Actions

Authored by nicolasfella on Mar 16 2018, 2:40 AM.

Details

Reviewers
mgallien
Group Reviewers
Elisa
Commits
R255:184f15b85810: Don't rely on playPause for MPRIS pause
Summary

When pause is requested via MPRIS playPause is called internally. Plasma sends pause when the laptop lid is closed. Now, when Elisa is open, but paused and Plasma sends pause, playPause is resulting in play, making Elisa play for
a couple of seconds before the laptop suspends.

Test Plan

Check via DBUS inspector and by closing/opening lid.

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Mar 16 2018, 2:40 AM
nicolasfella created this revision.
mgallien accepted this revision.Mar 16 2018, 6:03 AM
mgallien added a subscriber: mgallien.

Thanks a lot. One more bug removed from Elisa.
Please can you land it in 0.1 branch and merge in master ?

This revision is now accepted and ready to land.Mar 16 2018, 6:03 AM
Closed by commit R255:184f15b85810: Don't rely on playPause for MPRIS pause (authored by nicolasfella). · Explain WhyMar 16 2018, 3:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/mpris2/mediaplayer2player.cpp (2 lines)

Diff 29688

View Options

src/mpris2/mediaplayer2player.cpp

Loading...