Differential D11369

filter less files from bin/data for Elisa (including dbus needed files)
ClosedPublic
Actions

Authored by mgallien on Mar 15 2018, 8:57 PM.

Details

Reviewers

vonreth

Group Reviewers

Craft

Commits

R877:8f118bcdd653: filter less files from bin/data for Elisa (including dbus needed files)

Summary

filter less files from bin/data for Elisa (including dbus needed files)

Test Plan

elisa starts after dbus-server

Diff Detail

Repository

R877 Craft Blueprints for KDE

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien requested review of this revision.Mar 15 2018, 8:57 PM

mgallien created this revision.

If it works it's OK, I can't tell much from a blacklist.
We now ship hunspell instead of aspell.
What do you need dbus for?

This revision is now accepted and ready to land.Mar 15 2018, 9:30 PM

In D11369#226855, @vonreth wrote:

If it works it's OK, I can't tell much from a blacklist.
We now ship hunspell instead of aspell.
What do you need dbus for?

I do not need it on Windows but I also do not deactivate it. This is the other solution: always ignore dbus on Windows. I do not know which one is better or more Windows native.

The goal of this change is also to not blacklist the configuration kcm of Elisa.

If you are 100% sure you can also ignore dbus from the dependency resolution like in https://github.com/KDE/craft-blueprints-kde/blob/master/kde/applications/kate/kate.py#L55

Closed by commit R877:8f118bcdd653: filter less files from bin/data for Elisa (including dbus needed files) (authored by mgallien). · Explain WhyMar 18 2018, 9:15 PM

This revision was automatically updated to reflect the committed changes.

mgallien mentioned this in D11760: ignore DBus when packaging Elisa music player.Mar 27 2018, 8:40 PM

mgallien mentioned this in R877:10737f744856: ignore DBus when packaging Elisa music player.Mar 28 2018, 4:25 AM

Revision Contents
Changeset List

			Path	Packages
M			kde/unreleased/elisa/blacklist.txt (17 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	29633	a3209f3		Mar 15 2018, 8:57 PM	★	★
Diff 2	29860	06245fc	R877:8f118bcdd653b4931810537965fe4ba3e7d42ab0	Mar 18 2018, 9:15 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
f9b6c26934d7	9bd0ce279c7b	a3209f34fa82	Matthieu Gallien	filter less files from bin/data for Elisa (including dbus needed files) (Show More…)	Mar 15 2018, 8:55 PM

Diff 29860

View Options

kde/unreleased/elisa/blacklist.txt