Preserve tab titles set by the user, when applying profile changes
ClosedPublic

Authored by ahmadsamir on Mar 15 2018, 6:36 PM.

Details

Summary

When applying profile changes don't touch tab titles explicilty set by
the user (via the rename tab dialog); the same goes when previewing
color schemes.

Update the tab text only if the user actually changed the the tab title
fomart in the rename tab dialog.

BUG: 354403
FIXED-IN: 18.04

Test Plan
  • In a konsole window with 2 or more tabs, rename a tab using the rename-tab dialog
  • Open the Edit Profile dialog and change some settings and save, also try previewing some color schemes; note that the tab title changes are kept
  • In the Edit Profile dialog, change the tab format on the Tabs page, and apply; note that the tab title the was renamed by the user isn't changed but the tab(s) whose name wasn't changed are affected by the tab title format setting change
  • Open the rename-tab dialog, don't change anything and click OK; now konsole doesn't count that as a tab title change

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Mar 15 2018, 6:36 PM
Restricted Application added a project: Konsole. · View Herald TranscriptMar 15 2018, 6:36 PM
ahmadsamir requested review of this revision.Mar 15 2018, 6:36 PM
hindenburg accepted this revision.Mar 16 2018, 12:54 AM

looks fine thanks

This revision is now accepted and ready to land.Mar 16 2018, 12:54 AM
hindenburg edited the summary of this revision. (Show Details)Mar 16 2018, 1:13 AM
This revision was automatically updated to reflect the committed changes.