Fix double top padding on scrollable pages with headers

Authored by ngraham on Mar 15 2018, 6:34 PM.


Group Reviewers

Kirigami was erroneously allocating extra top padding to ScrollablePages with headers, despite the fact that the headers allocale enough space for themselves automatically.

This patch fixes the issue and resolves a visual glitch in Discover arising from the use of standard ToolBarApplicationHeaders.

Test Plan

Viewed all pages in Kirigami Gallery and made sure there were no visual regressions.

Discover, before:

Discover, after:

Diff Detail

R169 Kirigami
fix-scrollablepage-redundant-top-padding (branched from master)
No Linters Available
No Unit Test Coverage
ngraham created this revision.Mar 15 2018, 6:34 PM
Restricted Application added a project: Kirigami. · View Herald TranscriptMar 15 2018, 6:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mar 15 2018, 6:34 PM
ngraham edited the test plan for this revision. (Show Details)Mar 15 2018, 6:35 PM
mart added a comment.Mar 15 2018, 6:51 PM

that should be done also in the cards branch (tough this version is more correct)
if it's ok with you i would put this in the branch iinstead, otherwise there may be a conflict when merging

OK, I see that you just added the same fix to the cards branch, so I'll abandon this.

ngraham abandoned this revision.Mar 15 2018, 6:54 PM